fix(unit-tests): consistently check all store types#92
Merged
janickm merged 1 commit intoNVIDIA:mainfrom May 6, 2026
Merged
Conversation
Also fix type errors from now validated function bodies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fix type errors from now validated function bodies
This pull request improves the test coverage and maintainability of the V4 data components by parameterizing tests to run against both "itar" and "directory" store types, and by modernizing random number generation for better reproducibility. The changes also remove redundant assertions in array equality checks, making the tests cleaner and easier to read.
Test parameterization and coverage improvements:
Converted several test classes (
TestData4Reload,TestDataNewComponent, andTestPointCloudsSourceIntegration) to use@parameterized_class, ensuring all tests run for both"itar"and"directory"store types. This required changing test signatures and usingself.store_typeinstead of a parameter. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]Added
parameterizedandparameterized_classdependencies to the Bazel test target and test files. [1] [2] [3]Random data generation modernization:
np.random.randandnp.random.randintwithnp.random.default_rng().randomandnp.random.default_rng().integersfor all random data generation in tests, improving reproducibility and aligning with best practices. [1] [2] [3] [4] [5]Test code simplification:
self.assertIsNone(...)wrappers aroundnp.testing.assert_array_equalcalls in multiple places, as the array equality assertion is sufficient on its own. [1] [2] [3]